<html>
<head><meta charset="utf-8"><title>preferred reviewing workflow · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html">preferred reviewing workflow</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="215215632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215215632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215215632">(Oct 31 2020 at 22:53)</a>:</h4>
<p>I'm curious to hear: What are your preferred reviewing workflows? Do you review on GitHub, or locally with some other tool? And if you use GitHub, what review settings do you choose?</p>



<a name="215215683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215215683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215215683">(Oct 31 2020 at 22:55)</a>:</h4>
<p>I use github, usually with unified diff. If the PR has a lot of changes (or just is a refactor) I disable whitespace changes</p>



<a name="215215702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215215702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215215702">(Oct 31 2020 at 22:55)</a>:</h4>
<p>I oscillate between unified and split <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="215240097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215240097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215240097">(Nov 01 2020 at 11:30)</a>:</h4>
<p>Usually github + unified + ignore whitespace.</p>



<a name="215453827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215453827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215453827">(Nov 03 2020 at 13:40)</a>:</h4>
<p>yeah i use the default github review settings and for larger PRs, may review each commit separately</p>



<a name="215473753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215473753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215473753">(Nov 03 2020 at 16:05)</a>:</h4>
<p>Personally I'm growing a bit tired of a web based workflows. They are easy 'to learn" but a bit slow compared to a text-based one. Also, sporadic downtimes are annoying. Had lost in the past long comments. And sometimes <a href="#narrow/stream/122651-general/topic/github.20issues/near/214889942">they just break</a>.<br>
I will be experimenting moving also code reviews inside emacs (I use<code>magit</code>, an extension to manage everything about git)</p>



<a name="215515585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215515585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215515585">(Nov 03 2020 at 22:06)</a>:</h4>
<p><span class="user-mention" data-user-id="250987">@apiraino</span> So are you downloading the patch from GitHub and opening it in emacs? How do you submit review comments then?</p>



<a name="215554255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215554255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215554255">(Nov 04 2020 at 08:51)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215515585">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="250987">apiraino</span> So are you downloading the patch from GitHub and opening it in emacs? How do you submit review comments then?</p>
</blockquote>
<p>right now I just stick to the classic web workflow. I'm planning to test this extension and bring the review workflow into the IDE:<br>
<a href="https://github.com/charignon/github-review">https://github.com/charignon/github-review</a></p>
<p>(I think other IDEs are also moving into this direction)</p>



<a name="215554558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215554558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> vn-ki <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215554558">(Nov 04 2020 at 08:55)</a>:</h4>
<p>Magit was the number one (maybe the only) thing I missed when I switched away from emacs</p>



<a name="215613547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215613547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215613547">(Nov 04 2020 at 17:20)</a>:</h4>
<p>^no love for emacs keybindings? <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span> Personally, I like to pull the branch and compile it locally using a simple git change bar for highlighting changes in my IDE, mostly this is so I can freely scroll the whole file without clicking around wildly</p>



<a name="215628403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215628403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215628403">(Nov 04 2020 at 19:16)</a>:</h4>
<p>does anyone have suggestions for reviewing code that was moved into a separate file? <code>git diff -M -C</code> is failing me on <a href="https://github.com/rust-lang/rust/pull/76718/">https://github.com/rust-lang/rust/pull/76718/</a>, I think because the original files weren't deleted and the removed tests only make up part of the file.</p>



<a name="215628627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215628627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215628627">(Nov 04 2020 at 19:18)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/76327#issue-479741309">https://github.com/rust-lang/rust/pull/76327#issue-479741309</a> looks helpful</p>



<a name="215628755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215628755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215628755">(Nov 04 2020 at 19:19)</a>:</h4>
<p>oh wow, what a difference! <a href="/user_uploads/4715/iO9mfY33vTASwDS8DGFuESI1/dimmed.png">dimmed.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/iO9mfY33vTASwDS8DGFuESI1/dimmed.png" title="dimmed.png"><img src="/user_uploads/4715/iO9mfY33vTASwDS8DGFuESI1/dimmed.png"></a></div>



<a name="215628981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215628981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215628981">(Nov 04 2020 at 19:21)</a>:</h4>
<p>now if it could just hide whitespace changes we'd be all set ...</p>



<a name="215629386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215629386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215629386">(Nov 04 2020 at 19:24)</a>:</h4>
<p><code>git show -w --reverse --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change dda2b5e3e260c14b868c494008af1c8981eaa5a8..</code> is <em>beautiful</em><br>
<a href="/user_uploads/4715/IW1JpL8xp_M9nk52u4meNjrM/renamedno-whitespace.png">renamedno-whitespace.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/IW1JpL8xp_M9nk52u4meNjrM/renamedno-whitespace.png" title="renamedno-whitespace.png"><img src="/user_uploads/4715/IW1JpL8xp_M9nk52u4meNjrM/renamedno-whitespace.png"></a></div>



<a name="215630960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215630960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215630960">(Nov 04 2020 at 19:37)</a>:</h4>
<p>posted that on the tracking issue for renaming files: <a href="https://github.com/rust-lang/rust/issues/76268">https://github.com/rust-lang/rust/issues/76268</a></p>



<a name="215633562"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215633562" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215633562">(Nov 04 2020 at 19:58)</a>:</h4>
<p>These are pretty neat too:</p>
<ul>
<li><a href="https://github.com/dandavison/delta">https://github.com/dandavison/delta</a> (Written in rust <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span> )</li>
<li><a href="https://github.com/so-fancy/diff-so-fancy">https://github.com/so-fancy/diff-so-fancy</a></li>
</ul>



<a name="215633620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215633620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215633620">(Nov 04 2020 at 19:59)</a>:</h4>
<p>Side by side with delta is tricky when lines get really long tho <span aria-label="confused" class="emoji emoji-1f615" role="img" title="confused">:confused:</span></p>



<a name="215633668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215633668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215633668">(Nov 04 2020 at 19:59)</a>:</h4>
<p>that's ok, I prefer unified anyway</p>



<a name="215633700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215633700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215633700">(Nov 04 2020 at 19:59)</a>:</h4>
<p>for exactly that reason, it's hard to read on a narrow screen</p>



<a name="215633826"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215633826" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215633826">(Nov 04 2020 at 20:00)</a>:</h4>
<p>Unified works well in most cases unless there is a significant refactor then it kind of gets weird trying to read the diffs</p>



<a name="215635569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215635569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215635569">(Nov 04 2020 at 20:15)</a>:</h4>
<p><span class="user-mention silent" data-user-id="281950">Aman Arora</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215633562">said</a>:</p>
<blockquote>
<p>These are pretty neat too:</p>
<ul>
<li><a href="https://github.com/dandavison/delta">https://github.com/dandavison/delta</a> (Written in rust ;) )</li>
<li><a href="https://github.com/so-fancy/diff-so-fancy">https://github.com/so-fancy/diff-so-fancy</a></li>
</ul>
</blockquote>
<p>well that went badly <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> <a href="https://github.com/dandavison/delta/issues/378">https://github.com/dandavison/delta/issues/378</a></p>



<a name="215636761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215636761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215636761">(Nov 04 2020 at 20:26)</a>:</h4>
<p>There's also <a href="https://github.com/mookid/diffr">https://github.com/mookid/diffr</a></p>



<a name="215638038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215638038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215638038">(Nov 04 2020 at 20:37)</a>:</h4>
<p>I'd prefer not to install R unless I have to <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="215640245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215640245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215640245">(Nov 04 2020 at 20:56)</a>:</h4>
<p>What does <code>git show --reverse</code> do?</p>



<a name="215640535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215640535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215640535">(Nov 04 2020 at 20:59)</a>:</h4>
<p>not actually sure, I stole this from <span class="user-mention" data-user-id="209117">@lzutao</span></p>



<a name="215642057"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215642057" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215642057">(Nov 04 2020 at 21:13)</a>:</h4>
<p>I looked in the Git docs, but I couldn't find anything explaining <code>--reverse</code> for <code>git show</code> or <code>git diff</code> except for this:</p>
<blockquote>
<h1>Munging the diff output</h1>
<div class="codehilite"><pre><span></span><code>$ git diff --find-copies-harder -B -C  (1)
$ git diff -R                          (2)
</code></pre></div>

<ol>
<li>Spend extra cycles to find renames, copies and complete rewrites<br>
     (very expensive).</li>
<li>Output diff in reverse.</li>
</ol>
</blockquote>
<p>Whatever that means <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="215642104"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215642104" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215642104">(Nov 04 2020 at 21:13)</a>:</h4>
<p>It's like, thanks, I get that it's "in reverse", but what does that mean!?</p>



<a name="215642941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215642941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tyson Nottingham <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215642941">(Nov 04 2020 at 21:21)</a>:</h4>
<p>Well, obviously you should have checked <code>man git-log</code>. :)</p>
<div class="codehilite"><pre><span></span><code>       --reverse
           Output the commits chosen to be shown (see Commit Limiting section
           above) in reverse order. Cannot be combined with --walk-reflogs.
</code></pre></div>



<a name="215643440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215643440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215643440">(Nov 04 2020 at 21:25)</a>:</h4>
<p>I know that's what <code>git log --reverse</code> does, but <code>git show --reverse</code> is not behaving that way</p>



<a name="215643459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215643459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215643459">(Nov 04 2020 at 21:25)</a>:</h4>
<p>I do <code>git show --reverse</code> and it shows the <strong>latest</strong> commit, not the oldest</p>



<a name="215643841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215643841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215643841">(Nov 04 2020 at 21:29)</a>:</h4>
<p>I asked on Stack Overflow: <a href="https://stackoverflow.com/questions/64687993/what-does-git-show-reverse-do">https://stackoverflow.com/questions/64687993/what-does-git-show-reverse-do</a></p>



<a name="215643867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215643867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tyson Nottingham <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215643867">(Nov 04 2020 at 21:29)</a>:</h4>
<p>I think you'll see the difference when you specify multiple objects, as in <code>git show HEAD~2..</code>. I'm rusty with git though, TBH.</p>



<a name="215643972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215643972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215643972">(Nov 04 2020 at 21:30)</a>:</h4>
<p><span class="user-mention silent" data-user-id="306073">Tyson Nottingham</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215643867">said</a>:</p>
<blockquote>
<p>rusty</p>
</blockquote>
<p><span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="215644144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215644144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215644144">(Nov 04 2020 at 21:32)</a>:</h4>
<p>It looks like you're right re the <code>git show HEAD~2..</code> thing. Do you want to answer on stackoverflow or should I? (I don't want to take credit <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span>)</p>



<a name="215644266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215644266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tyson Nottingham <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215644266">(Nov 04 2020 at 21:34)</a>:</h4>
<p>Please, go ahead :)</p>



<a name="215658305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215658305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215658305">(Nov 05 2020 at 00:23)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215635569">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="281950">Aman Arora</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215633562">said</a>:</p>
<blockquote>
<p>These are pretty neat too:</p>
<ul>
<li><a href="https://github.com/dandavison/delta">https://github.com/dandavison/delta</a> (Written in rust <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span> )</li>
<li><a href="https://github.com/so-fancy/diff-so-fancy">https://github.com/so-fancy/diff-so-fancy</a></li>
</ul>
</blockquote>
<p>well that went badly <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> <a href="https://github.com/dandavison/delta/issues/378">https://github.com/dandavison/delta/issues/378</a></p>
</blockquote>
<p>Just noticed this. Ouch. I only use delta when I need split screen, which has been rare recently.   I guess I should've not recommended something that I haven't used on a daily basis</p>



<a name="215671066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/215671066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#215671066">(Nov 05 2020 at 04:49)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/215638038">said</a>:</p>
<blockquote>
<p>I'd prefer not to install R unless I have to <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>
</blockquote>
<p>But it's written in Rust. Though I'm not sure if helps here.</p>



<a name="216291737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216291737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216291737">(Nov 11 2020 at 00:00)</a>:</h4>
<p>OFC I have a copy of Rust Reference open somewhere in sight <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="216291856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216291856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216291856">(Nov 11 2020 at 00:01)</a>:</h4>
<p>other useful documents for reviewing?</p>



<a name="216310656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216310656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216310656">(Nov 11 2020 at 06:03)</a>:</h4>
<p>are there any private or internal team docs?</p>



<a name="216402825"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216402825" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216402825">(Nov 11 2020 at 21:48)</a>:</h4>
<p>I don't think there's much if any private documentation, but then again I wouldn't know if there were <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="216403162"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216403162" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216403162">(Nov 11 2020 at 21:52)</a>:</h4>
<p>There are some project- or wg- repositories under rust-lang that might have some information/ docs</p>



<a name="216403199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216403199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216403199">(Nov 11 2020 at 21:53)</a>:</h4>
<p>Not sure what you mean Rust reference (assuming lang/stdlib docs), there is rustc docs too here: <a href="https://doc.rust-lang.org/nightly/nightly-rustc/">https://doc.rust-lang.org/nightly/nightly-rustc/</a></p>



<a name="216403370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216403370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216403370">(Nov 11 2020 at 21:55)</a>:</h4>
<p>(deleted)</p>



<a name="216403546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216403546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216403546">(Nov 11 2020 at 21:56)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/216402825">said</a>:</p>
<blockquote>
<p>I don't think there's much if any private documentation, but then again I wouldn't know if there were <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>
</blockquote>
<p>oh yes, maybe try asking to see the secrets?</p>



<a name="216403928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216403928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216403928">(Nov 11 2020 at 22:00)</a>:</h4>
<p><del>precious</del></p>



<a name="216415575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216415575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216415575">(Nov 12 2020 at 00:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="281950">Aman Arora</span> <a href="#narrow/stream/122651-general/topic/preferred.20reviewing.20workflow/near/216403199">said</a>:</p>
<blockquote>
<p>Not sure what you mean Rust reference (assuming lang/stdlib docs), there is rustc docs too here: <a href="https://doc.rust-lang.org/nightly/nightly-rustc/">https://doc.rust-lang.org/nightly/nightly-rustc/</a></p>
</blockquote>
<p><a href="https://doc.rust-lang.org/nightly/reference/introduction.html">The Rust Reference</a> <br>
a highly useful source to me when reviewing</p>



<a name="216423263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/216423263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#216423263">(Nov 12 2020 at 03:15)</a>:</h4>
<p>ooh good to no</p>



<a name="217039661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/217039661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#217039661">(Nov 17 2020 at 18:04)</a>:</h4>
<p>In regards to diff enhancements I did come across this: <br>
<a href="https://diffoscope.org/">https://diffoscope.org/</a> interesting tool</p>



<a name="217052563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/preferred%20reviewing%20workflow/near/217052563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/preferred.20reviewing.20workflow.html#217052563">(Nov 17 2020 at 19:46)</a>:</h4>
<p>I've used it, it's very nice.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>